Skip to content

[Feature/#66] 릴리즈 환경 세팅#67

Merged
l5x5l merged 4 commits intodevelopfrom
feature/#66-release_setting
Jul 31, 2025
Merged

[Feature/#66] 릴리즈 환경 세팅#67
l5x5l merged 4 commits intodevelopfrom
feature/#66-release_setting

Conversation

@l5x5l
Copy link
Copy Markdown
Contributor

@l5x5l l5x5l commented Jul 31, 2025

[ PR Content ]

릴리즈 환경 세팅 작업을 수행합니다.

Related issue

Screenshot 📸

x

Work Description

  • 업로드 키 관련하여 github action, gradle 파일이 수정되었습니다

To Reviewers 📢

  • 릴리즈 버전 배포 관련해서 추가적으로 수정해야 하는데 빠뜨린 부분이 있다면 코멘트 부탁드립니다!

Summary by CodeRabbit

  • Chores
    • 릴리즈 빌드에 필요한 keystore 파일 및 관련 보안 정보를 자동으로 처리하도록 CI 워크플로우가 개선되었습니다.
    • 릴리즈 빌드 타입이 새로운 서명 구성을 사용하도록 업데이트되었습니다.

@l5x5l l5x5l self-assigned this Jul 31, 2025
@l5x5l l5x5l added ⚙ Init 개발 환경 세팅 세환 labels Jul 31, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 31, 2025

Walkthrough

릴리즈 빌드 환경을 위한 설정이 추가되었습니다. GitHub Actions 워크플로우에 keystore 파일 디코딩 및 관련 시크릿 처리 단계가 추가되었고, app/build.gradle.kts에는 릴리즈 서명 설정과 빌드 타입 연결이 반영되었습니다.

Changes

Cohort / File(s) Change Summary
CI 워크플로우 개선
.github/workflows/develop_branch.yml
base64로 인코딩된 keystore 파일을 디코딩하여 저장하는 단계 추가 및 local.properties에 릴리즈 키 관련 시크릿을 기록하는 로직 추가
릴리즈 서명 설정
app/build.gradle.kts
signingConfigs에 release 설정 추가, release 빌드타입에 해당 서명 설정 사용하도록 변경

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Secrets
    participant File System

    GitHub Actions->>Secrets: base64 keystore, key alias, key password, keystore password 요청
    Secrets-->>GitHub Actions: 시크릿 값 전달
    GitHub Actions->>File System: base64 keystore 디코딩 및 release.jks 저장
    GitHub Actions->>File System: local.properties에 시크릿 값 기록
    GitHub Actions->>Build: Gradle 빌드 실행 (릴리즈 빌드 시 서명 정보 사용)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective Addressed Explanation
릴리즈 빌드 관련 build.gradle 파일 수정 (#66)

Poem

릴리즈 준비, 토끼도 신나
keystore 숨기고, 시크릿을 담아
gradle에 서명, 워크플로우에 춤
빌드가 완성되면, 깡총깡총 붐!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca5ff8a and aa652be.

📒 Files selected for processing (1)
  • .github/workflows/develop_branch.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/develop_branch.yml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#66-release_setting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4244167 and ca5ff8a.

📒 Files selected for processing (2)
  • .github/workflows/develop_branch.yml (1 hunks)
  • app/build.gradle.kts (2 hunks)
🔇 Additional comments (2)
app/build.gradle.kts (1)

59-70: Release 빌드 설정 확인 필요

isMinifyEnabled = falseassembleDebug(CI) 조합으로는 실제 서명 릴리즈 APK 생성이 이루어지지 않습니다.
∙ Play 스토어 배포용이라면 isMinifyEnabled = true, assembleRelease 빌드 단계 추가를 검토해 주세요.

배포 전략에 따라 의도된 동작인지 한번 더 확인 부탁드립니다.

.github/workflows/develop_branch.yml (1)

29-40: 환경변수 네이밍 불일치

Gradle 스크립트는 RELEASE_KEYSTORE_PASSWORD (env) 를 찾지만 워크플로는
RELEASE_STORE_PASSWORD 를 사용해 local.properties 를 생성하고 있습니다.
네이밍을 통일하지 않으면 로컬 빌드/다른 CI 환경에서 예기치 않은 실패가 발생할 수 있습니다.

env: 블록과 시크릿 이름을 Gradle 스크립트와 동일한 RELEASE_KEYSTORE_PASSWORD 로 맞추는 것을 권장합니다.

Comment thread .github/workflows/develop_branch.yml
Comment thread app/build.gradle.kts
@l5x5l l5x5l requested a review from wjdrjs00 July 31, 2025 12:42
Copy link
Copy Markdown
Member

@wjdrjs00 wjdrjs00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

릴리즈 레츠기릿~~~!

@l5x5l l5x5l merged commit 691658a into develop Jul 31, 2025
2 checks passed
@l5x5l l5x5l deleted the feature/#66-release_setting branch July 31, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙ Init 개발 환경 세팅 세환

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] 릴리즈 환경 세팅

2 participants